Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mark inkscape 1.0 as unsupported (at least for now). #16394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

Mark inkscape 1.0 as unsupported (at least for now). #16394

merged 1 commit into from
Feb 3, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 3, 2020

The command line args changed completely so _SVGConverter would need to
be rewritted first.

See #15999.
Rather than rewriting the (rather complex) _SVGConverter I would actuall rather switch to cairosvg as converter, but this depends on Kozea/CairoSVG#259.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.2.0 milestone Feb 3, 2020
@anntzer
Mark inkscape 1.0 as unsupported (at least for now).
06d358c 
The command line args changed completely so _SVGConverter would need to
be rewritted first.
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #16394 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16394      +/-   ##
==========================================
- Coverage   80.85%   80.54%   -0.32%     
==========================================
  Files         307      307              
  Lines       75745    74408    -1337     
  Branches     9690     9687       -3     
==========================================
- Hits        61245    59930    -1315     
+ Misses      11961    11937      -24     
- Partials     2539     2541       +2
Impacted Files Coverage Δ
lib/matplotlib/testing/jpl_units/StrConverter.py 15.55% <0.00%> (-5.28%) ⬇️
lib/matplotlib/testing/jpl_units/EpochConverter.py 69.69% <0.00%> (-4.67%) ⬇️
lib/matplotlib/docstring.py 65.00% <0.00%> (-3.19%) ⬇️
...b/matplotlib/testing/jpl_units/UnitDblConverter.py 65.85% <0.00%> (-2.33%) ⬇️
lib/matplotlib/backend_managers.py 20.95% <0.00%> (-2.30%) ⬇️
lib/matplotlib/pyplot.py 71.76% <0.00%> (-1.14%) ⬇️
lib/matplotlib/animation.py 66.66% <0.00%> (-1.13%) ⬇️
lib/matplotlib/units.py 88.57% <0.00%> (-1.04%) ⬇️
lib/matplotlib/backends/backend_webagg.py 59.14% <0.00%> (-0.98%) ⬇️
lib/matplotlib/backend_tools.py 32.57% <0.00%> (-0.94%) ⬇️
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47fc9d...06d358c. Read the comment docs.

@tacaswell tacaswell merged commit ae764ae into matplotlib:master Feb 3, 2020
@anntzer anntzer deleted the ink1 branch February 3, 2020 16:40
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 3, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16394: Mark inkscape 1.0 as unsupported (at le…
4fe1e3b 
…ast for now).
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 3, 2020
Merged
tacaswell added a commit that referenced this pull request Feb 3, 2020
@tacaswell
Merge pull request #16397 from meeseeksmachine/auto-backport-of-pr-16…
fba292d 
…394-on-v3.2.x

Backport PR #16394 on branch v3.2.x (Mark inkscape 1.0 as unsupported (at least for now).)
@anntzer anntzer mentioned this pull request May 7, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
backend: svg topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @tacaswell