Thanks to visit codestin.com
Credit goes to github.com

Skip to content

close #16593: setting ecolor turns off color cycling #16597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2020
Merged

close #16593: setting ecolor turns off color cycling #16597

merged 3 commits into from
Mar 1, 2020

Conversation

story645
Copy link
Member

Co-authored-by: @tacaswell

PR Summary

Removed ecolor is not none from the codepath choosing between cycler and no cyclers; ecolor is none still defaults to cycler. This is arguably the preferred behavior as the user specifying the color of the errorbars does not tell us anything about what colors they'd like the actual plots to be (which is what cycler prefers).
A longer discussion should probably be had about cycler semantics - in which cases should the code default to the color the user passed in - I'm team basically any artist color not explicitly set should be controlled by the cycler.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant

@WeatherGod
Copy link
Member

Looks like there are some style issues in the new test:

./lib/matplotlib/tests/test_axes.py:3269:1: E302 expected 2 blank lines, found 1
./lib/matplotlib/tests/test_axes.py:3275:17: W291 trailing whitespace
./lib/matplotlib/tests/test_axes.py:3276:10: E111 indentation is not a multiple of four
./lib/matplotlib/tests/test_axes.py:3276:10: E117 over-indented
./lib/matplotlib/tests/test_axes.py:3276:35: E251 unexpected spaces around keyword / parameter equals
./lib/matplotlib/tests/test_axes.py:3276:43: E203 whitespace before ','
./lib/matplotlib/tests/test_axes.py:3276:60: W291 trailing whitespace
./lib/matplotlib/tests/test_axes.py:3278:1: W293 blank line contains whitespace
./lib/matplotlib/tests/test_axes.py:3281:10: E111 indentation is not a multiple of four
./lib/matplotlib/tests/test_axes.py:3281:10: E117 over-indented
./lib/matplotlib/tests/test_axes.py:3281:35: E251 unexpected spaces around keyword / parameter equals
./lib/matplotlib/tests/test_axes.py:3281:59: W291 trailing whitespace
./lib/matplotlib/tests/test_axes.py:3283:1: W293 blank line contains whitespace
./lib/matplotlib/tests/test_axes.py:3284:1: E302 expected 2 blank lines, found 1

@tacaswell tacaswell added this to the v3.3.0 milestone Feb 28, 2020
@tacaswell tacaswell linked an issue Feb 28, 2020 that may be closed by this pull request
specifying ecolor in errobar turns off cycling #16593
Closed
@tacaswell
Copy link
Member

This probably needs an API change note as something that did not used to cycle is now cycling?

@story645
Copy link
Member Author

@tacaswell not in love w/ the language I put there, but added behavior change entry.
@WeatherGod thanks, totally forgot to check on flake issues!

tacaswell
tacaswell approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo fixing the doc builds (think the decoration is too short)

@timhoffm timhoffm merged commit 12f2624 into matplotlib:master Mar 1, 2020
@story645 story645 deleted the errorbar branch June 8, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@WeatherGod WeatherGod WeatherGod approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
status: confirmed bug
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

specifying ecolor in errobar turns off cycling
5 participants
@story645 @WeatherGod @tacaswell @timhoffm @dstansby