-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Download qhull at build-or-sdist time. #16720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I change the PR title, but the commit message is still miss leading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 in principle.
Please fix the commit message, anyone can clear this review once that is done.
oops, fixed. |
rebased to use qhull 2020.2. @ianthomas23 feel free to force-push over the last PR to become recorded as author; I copy pasted your qhull_wrap.c from #16571 but couldn't cherry pick the commit as that change was not standalone. |
3fc40dc
to
06c7808
Compare
@anntzer for your information: You can acknowledge other authors via the commit message: |
nice, thanks. |
@anntzer I was thinking that if my name isn't on it, I can't be blamed if anything goes wrong with it in future! But it looks like you have already credited/blamed me 😃 |
Do we need to consider what to do with qhull's licence file (COPYING.txt)? We used to keep a copy in the |
I'll let @tacaswell decide on the legal stuff :) |
It will be built into the wheels, so we need to keep the license. Clause 2 says you must provide the license for any copies, so we should copy it into |
I now copy the license on unpack, and also just unified the codepaths with the freetype download/cache codepath. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this from a functional point of view as all triangulation tests perform as expected, and the license file is unpacked into the LICENSE
directory. I have just one documentation nitpick and there are some test failures but I think some of these are just timeouts.
(the current version) Co-authored-by: Ian Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this wasn't my favoured approach, it does fix the problem and I don't want to hold it up any longer. I am happy for it to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Slightly better naming/documentation possible.
The test failures are spurious I think... |
PR Summary
As suggested in #16571 (comment).
PR Checklist