Move widget functions into matplotlib.testing.widgets. #17030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I think that test has been failing for most of the day, we just need to investigate it separately... |
This comment has been minimized.
This comment has been minimized.
|
We have a preference for rebasing onto master rather than merging master in to the feature branch. Could you rebase (and force push) this @SidharthBansal ? The other option is we can squash merge. |
tacaswell
approved these changes
Apr 13, 2020
47957b9 to
5e9ec0c
Compare
|
I rebased and forced push. Thanks! |
QuLogic
previously requested changes
Apr 14, 2020
21e1598 to
5ada649
Compare
5ada649 to
d3750f7
Compare
dstansby
reviewed
Apr 19, 2020
QuLogic
reviewed
Apr 20, 2020
|
It's not really a breaking API change, as this is all new API. |
Co-Authored-By: Elliott Sales de Andrade <[email protected]>
Co-Authored-By: Elliott Sales de Andrade <[email protected]>
|
Thanks @QuLogic. I have completed the suggested changes. :) |
|
🐑 I miss read the UI and thought @QuLogic had previously approved it, but that was me so I merged this with one review, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #7372, move widget functions into matplotlib.testing.widgets.
Co-authored-by: @dakotablair
Closes #9905
PR Checklist