Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix running the test suite with inkscape>=1. #17351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Fix running the test suite with inkscape>=1. #17351

merged 1 commit into from
May 13, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 7, 2020

PR Summary

See #16394. May be nice for 3.3.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone May 7, 2020
@tacaswell
Copy link
Member

I verified that this works with inkscape 1.0 locally.

@tacaswell tacaswell mentioned this pull request May 7, 2020
Merged
@anntzer
Copy link
Contributor Author

anntzer commented May 9, 2020

rebased

QuLogic
QuLogic reviewed May 11, 2020
View reviewed changes
QuLogic
QuLogic reviewed May 12, 2020
View reviewed changes
QuLogic
QuLogic approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked in my testing with 1.0 and 0.92.

@QuLogic QuLogic merged commit a6f82b9 into matplotlib:master May 13, 2020
@anntzer anntzer deleted the inkscape1 branch May 13, 2020 08:19
@jklymak jklymak mentioned this pull request May 26, 2020
Merged
6 tasks
@QuLogic QuLogic mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
backend: svg topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic