Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inline FigureCanvasGtkFoo._render_figure. #17462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

Inline FigureCanvasGtkFoo._render_figure. #17462

merged 1 commit into from
May 23, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 20, 2020

Having it as a separate function obscures the flow for little benefit,
and caused an unnecessary call to get_allocation() in gtk3agg.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline FigureCanvasGtkFoo._render_figure.
d02b8be 
Having it as a separate function obscures the flow for little benefit,
and caused an unnecessary call to get_allocation() in gtk3agg.
@anntzer anntzer force-pushed the gtk_render_figure branch from 53e82d3 to d02b8be Compare May 22, 2020 09:21
@anntzer
Copy link
Contributor Author

anntzer commented May 22, 2020

rebased

@timhoffm timhoffm added this to the v3.3.0 milestone May 23, 2020
@timhoffm timhoffm merged commit fb9e723 into matplotlib:master May 23, 2020
@anntzer anntzer deleted the gtk_render_figure branch May 23, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: gtk Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @dstansby