Set colorbar label only in set_label. #17806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Jun 30, 2020
|
I guess it could get a test with the functionality in #17804? |
|
You (or whoever cares enough) get to push one ;) |
QuLogic
reviewed
Jul 1, 2020
| @@ -548,7 +548,6 @@ def _config_axis(self): | |||
| ticks_position=self.ticklocation) | |||
| short_axis.set_ticks([]) | |||
| short_axis.set_ticks([], minor=True) | |||
| self._set_label() | |||
There was a problem hiding this comment.
Does it still make sense to set self.stale = True here though?
... instead of doing so also in _config_axis. _config_axis is also called when e.g. the norm is changed, but we don't want to reset the label in that case. Note that the previous `self._labelkw` was only usable for one colorbar orientation anyways (because the choice of `_pos_kw` depends on the orientation) so everything was already tied to a single orientation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of doing so also in _config_axis.
_config_axis is also called when e.g. the norm is changed, but we don't
want to reset the label in that case.
Note that the previous
self._labelkwwas only usable for one colorbarorientation anyways (because the choice of
_pos_kwdepends on theorientation) so everything was already tied to a single orientation.
Closes #17804.
PR Summary
PR Checklist