Install on OpenBSD and FreeBSD #18088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
karolyi
approved these changes
Jul 27, 2020
dopplershift
approved these changes
Jul 28, 2020
QuLogic
requested changes
Jul 28, 2020
1 task
|
Now that #18092 is in and both @asherpasha and @karolyi indicated that they are happy with it I am going to close this (as my understanding of the current state is that we will now by default boot-strap our internal build of freetype, but you can opt to use the system one with an ENV and it will build reliably on *BSD systems). If I am wrong and we still need to pull the emergency parachute and require an external install on BSD we can re-open this. Even though it didn't go in, thank you very much @asherpasha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request fixes install on OpenBSD and FreeBSD. The related issue is #18057 and a related pull request is #17831
It is tested on the following:
OpenBSD 6.7-CURRENT Python 3.8.3
FreeBSD 12.1-RELEASE-p7 Python 3.8.5
PR Checklist