-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use same Make as FreeType's configure to build it. #18092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Namely, it's necessary to use `gmake` on BSD, since their `make` does not work.
@karolyi @asherpasha Does this work for you on BSD? Is it reasonable to require |
It builds on OpenBSD. So, personally, I am okay with either of the pull requests. |
It doesn't work for me. I tried without gmake, with gmake, with gmake and specifying Brace yourselves, huge build output below:
|
You're building |
I expect distro packages, like most others, will use existing FreeType from the distro, and thus disable this part of the build. |
With using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@QuLogic ? |
No, FreeType would not be necessary, only |
As long as it picks up the installed freetype package to build with, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging on the basis of the author, and the two reviews from folks who say this now works for them....
…092-on-v3.3.x Backport PR #18092 on branch v3.3.x (Use same Make as FreeType's configure to build it.)
Hi guys, I'm having the same issue on OpenBSD. Tried the above solution but I'm running into this:
Is there something obvious I'm missing? I was able to install the
|
the branch is nonexistent as it's been merged imo. try to install from https://github.com/matplotlib/matplotlib |
You were right. I replaced the |
PR Summary
Namely, it's necessary to use
gmake
on BSD, since theirmake
does not work.This translates the check from FreeType's
configure
shell script to our setup.This fixes #18057 on FreeBSD, assuming you have
gmake
installed, and may or may not be a better fix than #18088 (I don't know whether requiringgmake
is reasonable.)PR Checklist