allow webAgg to report middle click events #18172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current MouseEvent docstring has no mention of this issue so I did not remove anything there. This code was originally added to account for difficulties in preventing the context menu in chrome 23 matplotlib#1426 (comment)
|
The right-click menu should be fixed by #18142, so yes, that comment is outdated. |
QuLogic
approved these changes
Aug 4, 2020
|
I added a note.
Only 4 days ago! I guess I got lucky with my timing |
QuLogic
reviewed
Aug 5, 2020
Co-authored-by: Elliott Sales de Andrade <[email protected]>
timhoffm
approved these changes
Aug 5, 2020
|
Anybody can merge after CI pass. |
|
Thanks @ianhi! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Sep 10, 2020
This was fixed by matplotlib#18172.
2 tasks
danuo
pushed a commit
to danuo/matplotlib
that referenced
this pull request
Sep 11, 2020
This was fixed by matplotlib#18172.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the code in webAgg_core that prevented a user from being able to differentiate between middle click and right click events with a
mouse_button_eventcallback. I removed this forcing of the reported button from 2->3. This code was originally added to account for difficulties in preventing the context menu in chrome 23 #1426 (comment) which in modern chrome should be possible. There was a comment asking to remove mention of this from the MouseEvent docstring, however the current docstring does not seem to mention this so I did not change anything there.Closes: matplotlib/ipympl#254
Closes: #18171
PR Summary
PR Checklist