Remove 3D attributes from renderer #18302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeatherGod
reviewed
Aug 20, 2020
b111f1b to
86d0fc1
Compare
WeatherGod
requested changes
Aug 21, 2020
ebac289 to
a61a68a
Compare
|
@WeatherGod I'm not sure if this answer it or not. This code: import matplotlib.pyplot as plt
import numpy as np
fig = plt.figure()
ax = fig.add_subplot(1, 1, 1, projection='3d')
s = ax.plot_surface(np.ones((4,4)), np.ones((4,4)), np.ones((4,4)))
plt.draw()
s.do_3d_projection(fig.canvas.renderer)currently produces a warning: |
WeatherGod
approved these changes
Oct 21, 2020
timhoffm
reviewed
Oct 22, 2020
| # Then axes | ||
| for axis in self._get_axis_list(): | ||
| axis.draw(renderer) | ||
| props3d = { |
There was a problem hiding this comment.
Please add a note which of the following code can be removed once the deprecation expires.
There was a problem hiding this comment.
Basically all of it... Updated the comment.
All `Artist`s have a `.axes` attribute from which they can grab any of these things directly.
All internal Artists use `self.axes.*` instead.
a61a68a to
a769837
Compare
timhoffm
approved these changes
Oct 23, 2020
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
There's no need to do so, as artists have
.axesproperty from which they can get the same information. Since this is a weird internal undocumented draw thing, I'm not sure if it needs a deprecation/API note.PR Checklist