Use fig, ax = plt.subplots() in tests#18553
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Sep 24, 2020
Merged
Conversation
jklymak
approved these changes
Sep 24, 2020
tacaswell
approved these changes
Sep 24, 2020
Member
tacaswell
left a comment
There was a problem hiding this comment.
I am hesitant to make too many changes to the tests (as we don't have tests on the tests) in general, but not hesitant enough to reject this change.
Member
|
Travis passed, even though it is 'waiting' twice. |
Member
Author
That's fair. OTOH test code should be concise. And it may serve as a reference for users, which is why we should not use outdated or uncommon ideoms there. IMHO a careful cleanup is advisable. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use
instead of
The latter was a common pattern in tests. The former is shorter and thus adds less clutter to the tests.
More similar patterns could be replaced, but that's for another time.
Also fixed here along the way:
plt.errorbarinstead ofax.errorbar- we should test using the OOP API unless we want to test pyplot specifically.