Small simplifications to FloatingAxesBase. #20191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it? That patch is the clip path, not the Axes patch, so |
|
Ah, fair point, changed back. |
- _axes_class_floating is just the `super(FloatingAxesBase, self)` class (per its definition in floatingaxes_class_factory), so we can just use super-calls instead of explicitly referring to it (both in `__init__` and in `cla`); and then we can just delete _axes_class_floating. - Combine _gen_axes_patch into a single line (it's not as if the intermediary variable names were particularly helpful). - In cla(), the super() axes patch is already not in the draw tree (it's FloatingAxesBase._gen_axes_patch() which is there, so no need to adjust its visibility). _original_patch is never used anywhere, so delete it.
timhoffm
approved these changes
May 12, 2021
QuLogic
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super(FloatingAxesBase, self)class(per its definition in floatingaxes_class_factory), so we can just use
super-calls instead of explicitly referring to it (both in
__init__and in
cla); and then we can just delete _axes_class_floating.intermediary variable names were particularly helpful).
(it's FloatingAxesBase._gen_axes_patch() which is there, so no need
to adjust its visibility);
its figure and transform are already set. Finally,by super().cla() as well so no need to adjust them
_original_patch is never used anywhere, so delete it.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).