Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Quadmesh's default value of shading is now set to 'flat' instead of False #20332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2021

Conversation

jeffreypaul15
Copy link
Contributor

@jeffreypaul15 jeffreypaul15 commented May 29, 2021

PR Summary

Fixes #20322

The default value is now updated and tests for both the old and new Quadmesh signatures for their default value.
I've also updated the previous faulty changelog.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.5.0 milestone May 29, 2021
@QuLogic QuLogic added API: argument checking API: changes Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels May 29, 2021
@jklymak jklymak merged commit 0b741ee into matplotlib:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: argument checking API: changes Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuadMesh default for shading inadvertently changed.
3 participants