Refactor hexbin(). #21352
Merged
Refactor hexbin(). #21352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you claiming the factor of two is expected? This PR doesn't seem to change anything.... |
|
I'm not claiming it is expected (my quick guess is that it isn't), I'm just saying that the current implementation has |
5441bf6 to
50d6db0
Compare
I find the names
|
|
tx/ty it is. |
timhoffm
reviewed
Oct 14, 2021
timhoffm
reviewed
Oct 15, 2021
timhoffm
approved these changes
Oct 16, 2021
- Avoid having to copy() `x` and `y`, by not overwriting the original `x` and `y` variables but instead storing the transformed values in `trfx`/`trfy`. - Directly construct lattice1 and lattice2 as flat arrays (they are flattened at the end anyways), which allows using flat indices: the `C is None` case, becomes a simple `bincount`, the `C is not None` case can use a list-of-lists instead of an object array. - Factor out the x/y marginals handling into a for-loop, which additionally allows inlining coarse_bin. - Make the factor of 2 between nx and ny clearer (in the `for zname...` loop setup). - Construct marginals `verts` in a vectorized fashion.
jklymak
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xandy, by not overwriting the originalxandyvariables but instead storing the transformed values intrfx/trfy.flattened at the end anyways), which allows using flat indices:
the
C is Nonecase, becomes a simplebincount, theC is not Nonecase can use a list-of-lists instead of an object array.
additionally allows inlining coarse_bin.
for zname...loop setup). (See also [Bug]: Hexbin gridsize interpreted differently for x and y #21349 (comment).)
vertsin a vectorized fashion.Even if we decide to ultimately deprecate
marginals, this should help with converting them to a reusable examples entry.PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).