Fix passing stem markerfmt positionally when locs are not given #23232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2022
oscargus
reviewed
Jun 10, 2022
oscargus
reviewed
Jun 10, 2022
| _assert_equal(ax.stem(x, y, linefmt='r--'), expected=(x, y)) | ||
| _assert_equal(ax.stem(x, y, linefmt='r--', basefmt='b--'), expected=(x, y)) | ||
| _assert_equal(ax.stem(y, linefmt='r--'), expected=([0, 1, 2], y)) | ||
| _assert_equal(ax.stem(y, 'r--'), expected=([0, 1, 2], y)) |
Member
There was a problem hiding this comment.
Test somewhere that the lines actually are red and dashed?
Member
Author
78b881e to
3ac90b0
Compare
the signature is stem([locs], heads, linefmt=None, ...) So we should support both: ``` stem(heads, linefmt='r') stem(heads, 'r') ``` We had a kwonly deprecation for 3.5 that was aiming at `stem([locs], heads, *, linefmt=None, ...)` but now I'd rather relax this to `stem([locs], heads, linefmt=None, *, ...)` because it's reasonable to still support `stem(heads, 'r')`. That's analogous to `plot(y, 'r')`. The code overhead for supporting both positional and keyword passing for the single `linefmt` parameter is bearable.
oscargus
approved these changes
Jun 11, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 17, 2022
… when locs are not given
QuLogic
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 21, 2022
… when locs are not given
timhoffm
added a commit
that referenced
this pull request
Jun 21, 2022
…232-on-v3.5.x Backport PR #23232 on branch v3.5.x (Fix passing stem markerfmt positionally when locs are not given)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the signature is
stem([locs], heads, linefmt=None, ...)So we should support both:
We had a kwonly deprecation for 3.5 that was aiming at
stem([locs], heads, *, linefmt=None, ...)but now I'd rather relax this to
stem([locs], heads, linefmt=None, *, ...)because it's reasonable to still support
stem(heads, 'r'). That'sanalogous to
plot(y, 'r'). The code overhead for supporting bothpositional and keyword passing for the single
linefmtparameteris bearable.