Small TransformWrapper cleanups. #24640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5c6c24 to
7edd731
Compare
QuLogic
approved these changes
Dec 7, 2022
|
Perhaps we should be testing the incorrect dimensions exception as well? |
|
sure, done. |
Move _init() and _set() into set(). _init was split out in 5478183 to improve the pickling of TransformWrappers but was made unnecessary in 08387d8 following improvements in pickling in recent Pythons. _set and set can also easily be combined. Make input_dims, output_dims straight properties similarly to is_affine & friends; and improve the error message for mismatched dimensions (to indicate the wrong values).
ksunden
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move _init() and _set() into set().
_init was split out in 5478183 to improve the pickling of TransformWrappers but was made unnecessary in 08387d8 following improvements in pickling in recent Pythons. _set and set can also easily be combined.
Make input_dims, output_dims straight properties similarly to is_affine & friends; and improve the error message for mismatched dimensions (to indicate the wrong values).
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst