-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Check file path for animation and raise if it does not exist #25238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An alternative way to do this which would shift the error handling upstream, would be call |
[Side point: I did not know about the Path.resolve() trick to move error generation to the stdlib itself; it is nice because you can actually get the FileNotFoundError, PermissionError, or whatnot. (Perhaps the call should really be Path.stat(), though, as can be seen by looking at the implementation of Path.exists()). From a quick skim through the library, I think the only other place where we could switch to using it is at the start of matplotlib.testing.compare.convert().] |
64196ba
to
51af37f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures look real
51af37f
to
6383a57
Compare
It was indeed real... Wasn't sure if it was local so went ahead. The class structure could really need an update. Now, one cannot call |
6383a57
to
1453e02
Compare
OK, this should now be good to go. OS-dependent tests added. |
… if it does not exist
…238-on-v3.7.x Backport PR #25238 on branch v3.7.x (Check file path for animation and raise if it does not exist)
PR Summary
Closes #25233
Not clear to me how to check it. As in how the animation testing actually works... Once setup, I am sure how to test for the particular error.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst