-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
oss class #26248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oss class #26248
Conversation
It is not possible for `get_marker` to return another `MarkerStyle`; the `__init__` only takes one to make a full copy of it. And `get_alt_path` is only available for e.g., half-filled markers, but not all.
Drop metadata table when subsetting fonts
Fix MarkerStyle types
* The Scientific Python org is requesting that users of the https://pypi.anaconda.org/scipy-wheels-nightly/ package index migrate nightly builds to the new package index https://pypi.anaconda.org/scientific-python-nightly-wheels/ which will have community support moving forward. - c.f. https://scientific-python.org/specs/spec-0004/ - c.f. https://github.com/matplotlib/matplotlib/ PR 25950
This allows verifying that wheels can be installed after building, and that the sdist can be built into a wheel without a second workflow. Also simplify some of the checking scripts.
…location DOC: Use scientific-python-nightly-wheels for nightly build index
ci: Merge sdist and wheel building workflows
Co-authored-by: Tim Hoffmann <[email protected]> Co-authored-by: Ruth Comer <[email protected]>
Upload nightlies to new location
* Use the scientific-python/upload-nightly-action GitHub Action to upload the nightly wheels to the scientific-python-nightly-wheels Anaconda Cloud package index (https://anaconda.org/scientific-python-nightly-wheels). For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit sha and comment as new releases come out. - c.f. https://github.com/scientific-python/upload-nightly-action
* Remove the workflow step for querying and removing all but the last 5 nightly wheel uploads to the scientific-python-nightly-wheels Anaconda Cloud package index as this is now centrally done by the Scientific Python org for all projects that upload to https://anaconda.org/scientific-python-nightly-wheels. - c.f. scientific-python/upload-nightly-action#12
* For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit SHA and comment as new releases come out. - c.f. https://github.com/scientific-python/upload-nightly-action
good first issue bot rewording
... by inlining _reset_locators_and_formatters and _break_share_link; and, in the case of twinned axes, relying on groupers allowing the removal of elements not in the grouper at all. Also document that latter behavior.
Including whitespace seems to be the current behavior for agg and makes right-alignment works as it does. It is also necessary to make e.g. the currently PR'ed rainbow_text (based on `annotation(..., xycoords=textobj)` implementation work. Documenting the behavior is in particular useful for third-party backend implementers (mplcairo got this wrong previously).
Co-authored-by: Tim Hoffmann <[email protected]>
Better document the semantics of get_text_width_height_descent.
Simplify delaxes.
Correct spelling in 'Good first issue'
added alias to gray and grey match same colormaps
removed wrapping from first-issue-bot
Set transform for offset text in 3d
FIX: also copy the axis units when creating twins
FIX: AnnotationBbox extents before draw
…asked_invalid Fix: pcolormesh writing to read-only input mask
…code Use CLOSEPOLY kind code to close tricontourf polygons
Co-authored-by: Maria Malykh <[email protected]>
FIX: pcolor writing to read-only input mask
DOC: replaced step with stairs in basic plot types
Add missing parathesis to FancyBboxPatch docstring for correct type hinting.
Update FancyBboxPatch docstring
Thank you for your contribution. I think that probably you are not aiming for the 3.7.x branch as you are currently backpacking the whole main branch to 3.7.x. It may be that it is clearer what your change actually is once you target the correct branch, but it would also be useful to have a description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
This branch has no differences with our main branch. So I think this PR was opened by mistake. |
PR summary
PR checklist