Open source software development process course homework exercises #26250
Conversation
|
FYI, this branch only contains a new file with a statement similar to your post. There are no modifications to the actual code. Regarding the change, I believe that there was consensus in the discussion of an earlier attempt that the way to solve this is to make the arrow fully flexible. (Although I personally agree that what you have proposed do solve that particular issue and is easier for the user, although clearly less flexible.) |
|
@hybplayer from the description (and #26248) , it looks like you are going through some coursework and opening PRs to matplotlib to practice (if this is not the case, feel free to ignore!) While we welcome contributions, it would be better if any exercises were done on your own fork, since every PR opened on this repository will generate notifications for hundreds of people. Let us know if you need help with contributing to matplotlib - please take a look at our contributing guide for more details. |
|
I am going to go ahead and close this for now. @hybplayer Please re-open a new PR (from a feature branch!) when you have made progress in addressing an issue. |
PR summary
Our group chose this issue in the course of open source software development, trying to make a small contribution through our efforts.
This is our first contribution to an open-source project. This PR is to address the concerns raised in #24618. I've added the ability to specify fhead in the boxstyle attributes. By specifying "fhead=True" for DArrow, LArrow, or RArrow, this makes the head of the arrow flush with the top and bottom of the body.
PR checklist
Documentation and Tests
[Unsure] Has pytest style unit tests (and pytest passes)
Documentation is sphinx and numpydoc compliant (the docs should build without error).
(Need help] New plotting related features are documented with examples.
Release Notes
(Unsure] New features are marked with a .. versionadded:: directive in the docstring and documented indoc/users/next whats new/
(Unsure] API changes are marked with a .. versionchanged:: directive in the docstring and documented indoc/api/next api changes/
[Unsure] Release notes conform with instructions in next whats-new/README.rst or next api changes/README.rst