Deprecate cbook.Stack. #26294
Merged
Deprecate cbook.Stack. #26294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make the whole |
It's really not something we need to provide as public API.
|
Good point, done. |
oscargus
approved these changes
Jul 13, 2023
timhoffm
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods date back to when cbook.Stack also backed AxesStack, but now AxesStack is completely separate (#22114), Stack only backs the toolbar's home/forward/back buttons, and the methods don't make much sense in this class anymore.It's really not something we need to provide as public API.
Also, backends don't need to access the private _elements attribute.
PR summary
PR checklist