ps: Add option to use figure size as paper size #26479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15bb499 to
d2d5cd4
Compare
|
It's a bit of a smoke test, but I've added checks for the various combinations of ps output. |
tacaswell
reviewed
Aug 9, 2023
| PostScript paper type defaults to figure size | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The :rc:`ps.papertype` rcParam no longer defaults to 'letter' paper, but |
There was a problem hiding this comment.
This does not match what the code does.
d2d5cd4 to
f5d1dbe
Compare
ksunden
approved these changes
Aug 9, 2023
We already set the bounding box to coincide with the figure size, but setting an overall paper size can sometimes cause the resulting file to be cropped by the viewer. We additionally need to pass this through to the distiller.
f5d1dbe to
740c5d7
Compare
When a distiller is not found, that step is simply skipped by `_try_distill`, so these tests were not actually skipped as intended.
5d0ec0e to
96b26fe
Compare
|
Meant to squash merge to fix the commit message which incorrectly indicates the default changed, unfortunately forgot to do so and now it is not trivial to fix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
We already set the bounding box to coincide with the figure size, but setting an overall paper size can sometimes cause the resulting file to be cropped by the viewer.
We additionally need to pass this through to the distiller.
Fixes #16657
PR checklist