Added test for broken_barh to test_datetime.py#27428
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you! I think it makes sense to remove the labels and the caption though (as that will test unrelated things). |
2683e70 to
cad6d11
Compare
|
I have removed all labels and titles as per @oscargus request. I noticed that there are some failing tests on my branch that seem to be for |
ksunden
left a comment
There was a problem hiding this comment.
I don't see any reason this would be connected to that failed test, though I've not known that to be a flaky test in the past... I'll rerun those tests to be sure, but everything looks fine here, AFAIK
|
Thanks @avramid9! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
Added code for
test_broken_barhintest_datetime.pyas requested in #26864Here is an image of the output:
PR checklist