Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added test for broken_barh to test_datetime.py #27428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

Added test for broken_barh to test_datetime.py #27428

merged 1 commit into from
Dec 5, 2023

Conversation

avramid9
Copy link
Contributor

@avramid9 avramid9 commented Dec 3, 2023

PR summary

Added code for test_broken_barh in test_datetime.py as requested in #26864

Here is an image of the output:
test_broken_barh

PR checklist

github-actions[bot]
github-actions bot reviewed Dec 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@oscargus oscargus mentioned this pull request Dec 4, 2023
Open
64 tasks
@oscargus
Copy link
Member

oscargus commented Dec 4, 2023

Thank you! I think it makes sense to remove the labels and the caption though (as that will test unrelated things).

@avramid9
Copy link
Contributor Author

avramid9 commented Dec 5, 2023

I have removed all labels and titles as per @oscargus request. I noticed that there are some failing tests on my branch that seem to be for test_pylab_integration. I am not 100% sure but I don't think this would be caused by the test that I added. Are these known to have flaky behavior?

ksunden
ksunden approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason this would be connected to that failed test, though I've not known that to be a flaky test in the past... I'll rerun those tests to be sure, but everything looks fine here, AFAIK

@QuLogic QuLogic merged commit 2ccc703 into matplotlib:main Dec 5, 2023
@QuLogic QuLogic added this to the v3.9.0 milestone Dec 5, 2023
@QuLogic
Copy link
Member

QuLogic commented Dec 5, 2023

Thanks @avramid9! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@avramid9 @oscargus @QuLogic @ksunden