Added test for Axes.bar_label#27431
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
jklymak
left a comment
There was a problem hiding this comment.
Ooops, approved too quickly. This no longer has bar_label! Though likely a fine test for ax.bar if there isn't one already.
|
#27033 is a test for I think you can just add back the |
|
Apologies for the mistake! I added back a line with the bar_label function let me know how it looks now/ if there is anything else I should change |
Changed axs to ax Co-authored-by: Elliott Sales de Andrade <[email protected]>
|
Thanks @KheshavKumar! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
… added mpl.rcParams to clean up axes labelling.
PR summary
I have added a datetime/timedelta smoke test for Axes.bar_label in lib/matplotlib/tests/test_datetime.py.
This addresses the Axes.bar_label task from #26864.
PR checklist