Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added test for Axes.bar_label #27431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 7, 2023
Merged

Added test for Axes.bar_label #27431

merged 10 commits into from
Dec 7, 2023

Conversation

KheshavKumar
Copy link
Contributor

@KheshavKumar KheshavKumar commented Dec 3, 2023 •
edited
Loading

PR summary

I have added a datetime/timedelta smoke test for Axes.bar_label in lib/matplotlib/tests/test_datetime.py.
This addresses the Axes.bar_label task from #26864.

image

PR checklist

github-actions[bot]
github-actions bot reviewed Dec 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

jklymak
jklymak reviewed Dec 3, 2023
View reviewed changes
jklymak
jklymak reviewed Dec 3, 2023
View reviewed changes
jklymak
jklymak approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

jklymak
jklymak requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, approved too quickly. This no longer has bar_label! Though likely a fine test for ax.bar if there isn't one already.

@ksunden
Copy link
Member

ksunden commented Dec 4, 2023

#27033 is a test for bar, which also exercises e.g. the width and bottom args.

I think you can just add back the bar_label call and be good... I could see an argument for testing dates on each of the axes, but not so concerned with bar_label compared to a lot of methods, so we can start with just the simple case, I think.

ksunden
ksunden reviewed Dec 4, 2023
View reviewed changes
@QuLogic QuLogic mentioned this pull request Dec 5, 2023
Open
64 tasks
@KheshavKumar
Copy link
Contributor Author

Apologies for the mistake! I added back a line with the bar_label function let me know how it looks now/ if there is anything else I should change

QuLogic
QuLogic reviewed Dec 5, 2023
View reviewed changes
@KheshavKumar @QuLogic
Update lib/matplotlib/tests/test_datetime.py
1d5630e 
Changed axs to ax

Co-authored-by: Elliott Sales de Andrade <[email protected]>
@QuLogic QuLogic added this to the v3.9.0 milestone Dec 7, 2023
@QuLogic QuLogic merged commit 302fd39 into matplotlib:main Dec 7, 2023
@QuLogic
Copy link
Member

QuLogic commented Dec 7, 2023

Thanks @KheshavKumar! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

bikegeek added a commit to bikegeek/matplotlib that referenced this pull request Dec 8, 2023
@bikegeek
Added test for Axes.hexbin (matplotlib#27431)
1964eab
bikegeek added a commit to bikegeek/matplotlib that referenced this pull request Dec 8, 2023
@bikegeek
Added test for Axes.hexbin (matplotlib#27431)
6d5038f
bikegeek added a commit to bikegeek/matplotlib that referenced this pull request Dec 8, 2023
@bikegeek
Added test for Axes.hexbin (matplotlib#27431), with additional plots.
c6cae1b
bikegeek added a commit to bikegeek/matplotlib that referenced this pull request Dec 8, 2023
@bikegeek
Added test for Axes.hexbin (matplotlib#27431), with additional plots,…
231c99f 
… added mpl.rcParams to clean up axes labelling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: date handling topic: testing
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KheshavKumar @ksunden @QuLogic @jklymak