Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added test_pcolormesh in test_datetime.py #27433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added test_pcolormesh in test_datetime.py #27433

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40e8132
added a test for fill in test_datetime.py
nidaa-7 Nov 29, 2023
7de0d46
Removed saving the picture from test code.
nidaa-7 Nov 30, 2023
6322cc9
Added test for axes.pcolormesh
nidaa-7 Dec 3, 2023
a53ffcc
Merge remote-tracking branch 'origin/test-pcolormesh' into test-pcolo…
nidaa-7 Dec 4, 2023
6f4e568
Reverted changes in .gitignore
nidaa-7 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions lib/matplotlib/tests/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,11 +450,27 @@ def test_pcolorfast(self):
fig, ax = plt.subplots()
ax.pcolorfast(...)

@pytest.mark.xfail(reason="Test for pcolormesh not written yet")
@mpl.style.context("default")
def test_pcolormesh(self):
fig, ax = plt.subplots()
ax.pcolormesh(...)
fig, (ax1, ax2, ax3, ax4) = plt.subplots(4, 1, layout="constrained")

np.random.seed(19680801)

x_base_date = datetime.datetime(2023, 1, 1)
x_dates = [x_base_date + datetime.timedelta(days=i) for i in range(5)]

y_base_date = datetime.datetime(2023, 1, 1)
y_dates = [y_base_date + datetime.timedelta(days=i) for i in range(5)]

x_timestamps = [date.timestamp() for date in x_dates]
y_timestamps = [date.timestamp() for date in y_dates]
Comment on lines +465 to +466
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid using the timestamp for the non-date data, as it is a number that looks like it should be interpreted as a data (and thus made me do a doubletake when I saw the image)

Perhaps just do e.g. np.linspace(0, 10, x_dates.size) or something similar


data = np.random.rand(len(x_dates), len(y_dates))

ax1.pcolormesh(x_dates, y_dates, data, cmap='viridis')
ax2.pcolormesh(x_dates, y_timestamps, data, cmap='viridis')
ax3.pcolormesh(x_timestamps, y_dates, data, cmap='viridis')
ax4.pcolormesh(x_timestamps, y_timestamps, data, cmap='viridis')

@mpl.style.context("default")
def test_plot(self):
Expand Down