Added test_pcolormesh in test_datetime.py#27433
Open
nidaa-7 wants to merge 5 commits intomatplotlib:mainfrom
Open
Added test_pcolormesh in test_datetime.py#27433nidaa-7 wants to merge 5 commits intomatplotlib:mainfrom
nidaa-7 wants to merge 5 commits intomatplotlib:mainfrom
Conversation
64 tasks
ksunden
reviewed
Dec 5, 2023
Comment on lines
+465
to
+466
| x_timestamps = [date.timestamp() for date in x_dates] | ||
| y_timestamps = [date.timestamp() for date in y_dates] |
Member
There was a problem hiding this comment.
I would avoid using the timestamp for the non-date data, as it is a number that looks like it should be interpreted as a data (and thus made me do a doubletake when I saw the image)
Perhaps just do e.g. np.linspace(0, 10, x_dates.size) or something similar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Added code for
test_pcolormeshintest_datetime.pyas requested in #26864(old commits in this branch have already been merged #27401, only new additions are shown - the test_pcolormesh test)
Image of the plot:
PR checklist