-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add test_fill in test_datetime.py #27401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I had added my virtual environment to gitignore and pushed it. Reverted back before pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
(Edited the description just to prevent autoclosing of #26864, since this does not complete the whole of that issue, just one task (which is how that issue is designed)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! good job on setting the seed, this ensure the tests are consistent, and do not change with every run.
Thanks @nidaa-7! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
Added code for
test_fill
intest_datetime.py
as requested in #26864Image of an output:

PR checklist