Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test_fill in test_datetime.py #27401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Conversation

nidaa-7
Copy link
Contributor

@nidaa-7 nidaa-7 commented Nov 30, 2023

PR summary

Added code for test_fill in test_datetime.py as requested in #26864

Image of an output:
test_fill_output

PR checklist

I had added my virtual environment to gitignore and pushed it. Reverted back before pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ksunden
Copy link
Member

ksunden commented Nov 30, 2023

(Edited the description just to prevent autoclosing of #26864, since this does not complete the whole of that issue, just one task (which is how that issue is designed))

Copy link
Contributor

@rawwash rawwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good job on setting the seed, this ensure the tests are consistent, and do not change with every run.

@QuLogic QuLogic merged commit 17d8bf0 into matplotlib:main Dec 2, 2023
@QuLogic
Copy link
Member

QuLogic commented Dec 2, 2023

Thanks @nidaa-7! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@QuLogic QuLogic added this to the v3.9.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants