Add marker-only and line+marker visuals to the plot() plot types #27771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shows as
See also the built docs |
story645
reviewed
Feb 12, 2024
Inspired from the discussion in matplotlib#27765: We should visually communicate that `plot()` covers all three variants: markers only, line+markers, line-only. They are visually distinct enough that it's not possible to infer the variants if you see only one. In particular, it's important to communicate that you can draw markers only. We don't want to automatically drive people who want markers (e.g. some discrete measurements of a dependent variable y (x)) to scatter because that's the only one showing discrete markers in the overview.
1d3b18c to
2a59cb2
Compare
story645
approved these changes
Feb 12, 2024
dstansby
reviewed
Feb 12, 2024
dstansby
approved these changes
Feb 12, 2024
|
|
||
| # plot | ||
| fig, ax = plt.subplots() | ||
|
|
||
| ax.plot(x2, y2 + 2.5, 'x', markeredgewidth=2) |
There was a problem hiding this comment.
Suggested change
| ax.plot(x2, y2 + 2.5, 'x', markeredgewidth=2) | |
| ax.plot(x2, y2 + 2.5, fmt='x', markeredgewidth=2) |
| ax.plot(x, y, linewidth=2.0) | ||
| ax.plot(x2, y2 - 2.5, 'o-', linewidth=2) |
There was a problem hiding this comment.
Suggested change
| ax.plot(x2, y2 - 2.5, 'o-', linewidth=2) | |
| ax.plot(x2, y2 - 2.5, fmt='o-', linewidth=2) |
|
@dstansby passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from the discussion in #27765: We should visually communicate that
plot()covers all three variants: markers only, line+markers, line-only. They are visually distinct enough that it's not possible to infer the variants if you see only one.In particular, it's important to communicate that you can draw markers only. We don't want to automatically drive people who want markers (e.g. some discrete measurements of a dependent variable y (x)) to scatter because that's the only one showing discrete markers in the overview.