Revive sanitizing default filenames extracted from UI window titles #28275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked the wrong pr number. |
timhoffm
reviewed
May 22, 2024
greglucas
reviewed
Jun 8, 2024
timhoffm
approved these changes
Jun 11, 2024
I would actually think that we should not do any sanitization ("you get
what you asked for"), but given that there was some opposition last time
I tried to restore the space in the default filename ("Figure 1.png"),
even though the space is totally innocuous for the filesystem, we may as
well fix the filenames that are *actually* problematic.
Co-authored-by: Greg Lucas <[email protected]>
MNT: remove unneeded access of savefig.directory
This makes the default suggested filename independent of the OS.
47803f6 to
4356bfe
Compare
|
The failures were real and the tests caught a behavior change (this method should really return a file name not the full path and the save_dir was only used for the de-duplication logic that has also been subsequently removed. |
greglucas
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #9057 [edited to fix xref]