Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reset selector state when callbacks raise - #32332

Closed
LouisDeconinck wants to merge 1 commit into
matplotlib:mainfrom
LouisDeconinck:fix/span-selector-callback-cleanup-32327
Closed

Reset selector state when callbacks raise#32332
LouisDeconinck wants to merge 1 commit into
matplotlib:mainfrom
LouisDeconinck:fix/span-selector-callback-cleanup-32327

Conversation

@LouisDeconinck

Copy link
Copy Markdown

PR summary

Closes #32327.

Selector release handlers clear their internal press and release events in a finally block. This keeps a selector usable after an onselect or related callback raises an exception, while preserving the original exception for the caller.

AI Disclosure

This PR was prepared with Codex. I reviewed the implementation, test, and final description.

PR quality check

  • Use an expressive title
  • New and changed code is tested
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New features and API changes have release notes
  • [N/A] Documentation complies with general and docstring guidelines

@github-actions

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@iccir iccir added the ai-contribution PRs that are AI generated without a human in the loop label Sep 11, 2026
@iccir

iccir commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Closing this PR as it violates our Use of Generative AI Policy. The author opened 72 PRs over a 24 hour window, which implies the use of automated tooling to spam repositories.

I'm not banning the account as the author was at least truthful about AI usage in our PR template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-contribution PRs that are AI generated without a human in the loop first-contribution topic: widgets/UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: exception raised in SpanSelector callback puts the selector in an invalid state for later interactions

2 participants