Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Build dep updates #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2014
Merged

Build dep updates #3479

merged 3 commits into from
Sep 27, 2014

Conversation

tacaswell
Copy link
Member

This closes both #3423 and #3412.

@tacaswell tacaswell added this to the v1.4.1 milestone Sep 6, 2014
cimarronm
cimarronm reviewed Sep 6, 2014
View reviewed changes
setupext.py
try:
import pytz
except ImportError:
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be raise CheckFailed("...") otherwise you are going to get a positive (yes) return

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine because it will get added to the setup requirements list and pip-installed if it is not found.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. You may want to add pip may attempt to install it afterwards text in the return message like what is done in Dateutil

@mdboom
Copy link
Member

mdboom commented Sep 8, 2014

Isn't pytz a dep of dateutil, and thus already covered?

@tacaswell
Copy link
Member Author

There seems to be a dateutil (python-dateutil in pypi) and dateutils the former does not depend on pytz while the later does.

pip install dateutils results in pytz being installed

pip install matplotlib does not

@WeatherGod
Copy link
Member

dateutil and dateutils are two completely different packages (as I recently
learned), providing different features.
https://labix.org/python-dateutil
https://pypi.python.org/pypi/dateutils

On Mon, Sep 8, 2014 at 1:40 PM, Thomas A Caswell [email protected]
wrote:

There seems to be a dateutil (python-dateutil in pypi) and dateutils the
former does not depend on pytz while the later does.

pip install dateutils results in pytz being installed

pip install matplotlib does not

—
Reply to this email directly or view it on GitHub
#3479 (comment)
.

mdboom added a commit that referenced this pull request Sep 27, 2014
@mdboom
Merge pull request #3479 from tacaswell/build_dep_updates
ec894f6 
Build dep updates
@mdboom mdboom merged commit ec894f6 into matplotlib:v1.4.x Sep 27, 2014
@tacaswell tacaswell deleted the build_dep_updates branch September 27, 2014 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@tacaswell @mdboom @WeatherGod @cimarronm @QuLogic