Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Build dep updates #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2014
Merged

Build dep updates #3479

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99c04e9
BLD/BUG/DOC : made pytz a required dependency
tacaswell Sep 6, 2014
f40bf14
DOC : removed freetype version caveats
tacaswell Sep 6, 2014
ac62606
BLD : updated message when to pytz found
tacaswell Sep 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
BLD : updated message when to pytz found
  • Loading branch information
@tacaswell
tacaswell committed Sep 6, 2014
commit ac6260672d1144a73f29f00a9151f52ed35adfdc
4 changes: 3 additions & 1 deletion setupext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,9 @@ def check(self):
import pytz
except ImportError:
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be raise CheckFailed("...") otherwise you are going to get a positive (yes) return

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine because it will get added to the setup requirements list and pip-installed if it is not found.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. You may want to add pip may attempt to install it afterwards text in the return message like what is done in Dateutil

"pytz was not found.")
"pytz was not found. "
"pip will attempt to install it "
"after matplotlib.")

return "using pytz version %s" % pytz.__version__

Expand Down