Check for freetype header in freetype2 dir #3713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obviously this doesn't work on Travis so it would seem like we need to check both inside and outside the folder. |
|
Because the headers are in /usr/include/freetype2/freetype/ in Ubuntu 12.04 and ft2build.h in /usr/include/ |
|
Can you re-target this at master please? |
|
This is the wrong approach anyway. I hope to get around to solve this correctly soon if no one else beats me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building agains Xquartz freetype on OSX without pkg-config. The headers are inside the freetype2 dir so we need to look there.
Closes part of #3694
We need to test that this does not break the build on other platforms. Perhaps we should check both places?