-
-
Notifications
You must be signed in to change notification settings - Fork 8k
An example of TVGuide Heatmap #3964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tacaswell, do you need any additional help with this PR? |
Could you do two things, make the code pep8 compliant and re-write with a function which has a signature something like def tv_guide(ax, data, cmap=None, ...):
# do stuff |
The channels aren't in numerical order |
This example also requires pandas. What is our position on using pandas for examples? |
I missed the pandas dep. The precedent is to pre-reduce the data to something that can be shoved into a rec-array or a dict of arrays. It is a plotting example, not a data-cleaning example so we can assert we get clean data in ;) |
This is a neat example, but it isn't clear what it is supposed to be an example of. The comments need to highlight what it is trying to demonstrate, this can be done as a docstring at the top of the file (before or after imports? I can't remember). Also, anything extraneous needs to be minimized. So, if tick formatting is not the focus, then I would simplify that portion as much as possible, to the point of just simply using the default date ticking. Comments need to be added to explain logic. Having a comment of "x axis tick formatting" above the line of code that says "set_major_formatter" is a bit useless. I like to say that your code should be like Shakespeare, elegant, inspired, and beautiful, and your comments need to be like the cliff-notes. |
Ok, I'll update the code and eliminate the pandas dependency. @tacaswell may be you can suggest what can be the focus of the example, |
As this is just an example and needs some updates, no reason it has to hold up 2.0. |
@trnl Sorry this completely fell off my radar. You still interested in this or can it be adopted by others? |
I'm going to close this: its sat for a long time, I'm not sure that what it shows is all that helpful, and it uses pandas. If the original author wants to take it up again, it'd be great to work on it.... |
This change is