Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

trnl
Copy link

@trnl trnl commented Jan 3, 2015

This change is Reviewable

@tacaswell tacaswell added this to the v1.5.x milestone Jan 3, 2015
@trnl
Copy link
Author

trnl commented Jan 11, 2015

@tacaswell, do you need any additional help with this PR?

@tacaswell
Copy link
Member

Could you do two things, make the code pep8 compliant and re-write with a function which has a signature something like

def tv_guide(ax, data, cmap=None, ...):
    # do stuff

@WeatherGod
Copy link
Member

For those who are curious about what the example looks like:
tvguide_heatmap

@WeatherGod
Copy link
Member

The channels aren't in numerical order

@WeatherGod
Copy link
Member

This example also requires pandas. What is our position on using pandas for examples?

@tacaswell
Copy link
Member

I missed the pandas dep. The precedent is to pre-reduce the data to something that can be shoved into a rec-array or a dict of arrays. It is a plotting example, not a data-cleaning example so we can assert we get clean data in ;)

@WeatherGod
Copy link
Member

This is a neat example, but it isn't clear what it is supposed to be an example of. The comments need to highlight what it is trying to demonstrate, this can be done as a docstring at the top of the file (before or after imports? I can't remember).

Also, anything extraneous needs to be minimized. So, if tick formatting is not the focus, then I would simplify that portion as much as possible, to the point of just simply using the default date ticking. Comments need to be added to explain logic. Having a comment of "x axis tick formatting" above the line of code that says "set_major_formatter" is a bit useless.

I like to say that your code should be like Shakespeare, elegant, inspired, and beautiful, and your comments need to be like the cliff-notes.

@trnl
Copy link
Author

trnl commented Jan 12, 2015

Ok, I'll update the code and eliminate the pandas dependency. @tacaswell may be you can suggest what can be the focus of the example, broken_barh or clip_box?

@tacaswell tacaswell modified the milestones: proposed next point release, next point release Feb 19, 2015
@tacaswell tacaswell modified the milestones: next point release, Color overhaul Jul 16, 2015
@tacaswell tacaswell modified the milestones: Color overhaul, next major release (2.0) Oct 26, 2015
@tacaswell tacaswell modified the milestones: next bug fix release (2.0.1), next major release (2.0) Dec 14, 2015
@QuLogic
Copy link
Member

QuLogic commented Oct 23, 2016

As this is just an example and needs some updates, no reason it has to hold up 2.0.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Oct 23, 2016
@QuLogic QuLogic removed this from the 2.0.1 (next bug fix release) milestone Oct 23, 2016
@tacaswell
Copy link
Member

@trnl Sorry this completely fell off my radar.

You still interested in this or can it be adopted by others?

@tacaswell tacaswell modified the milestone: 2.1 (next point release) Aug 29, 2017
@jklymak
Copy link
Member

jklymak commented Jan 19, 2018

I'm going to close this: its sat for a long time, I'm not sure that what it shows is all that helpful, and it uses pandas. If the original author wants to take it up again, it'd be great to work on it....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants