Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pull Request Suggestion for #4062 #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

beachdweller
Copy link

Dear all,

I managed to prepare some modifications possibly fixing issue #4062. I understand it would be subjected to review and would welcome any suggestions and/or comments.

Good day

KW

…lated methods possibly including superclass methods (not overloaded)
…ension();

enabled command line testing;
added test for FreeType check();
added call to make_extension()
setUp() : reload setupext to make sure newest code is under test

renamed test_check_None() -> test_check() : expected return different

added test_get_extension() : calls FreeType get_extension() and pprint include_dirs
@@ -0,0 +1,37 @@
The objective of this Pull Request is to make installation more robust on mac's regarding freetype paths
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful information, but should not go into the repo as a tracked file. This seems better suited as a commit message or comments in the code.

@tacaswell
Copy link
Member

cc @jenshnielsen

@tacaswell
Copy link
Member

Please see http://matplotlib.org/devel/testing.html

@tacaswell
Copy link
Member

Related to #3976

@tacaswell tacaswell modified the milestones: proposed next point release, next point release Jul 16, 2015
@beachdweller
Copy link
Author

What does "All checks have failed" mean? Including this pull request, the build did not go through? (Happy Holidays and Happy New Year 2016)

@tacaswell
Copy link
Member

It means that the automated testing failed, follow the details link for the log.

@WeatherGod
Copy link
Member

The Travis failure is so old that the link for the build info is no longer available. I am going to close and re-open this PR so that it will re-try the test suite.

@tacaswell tacaswell modified the milestone: 2.1 (next point release) Aug 29, 2017
@anntzer
Copy link
Contributor

anntzer commented Jan 5, 2018

Closing as the original issue has been closed (#4062 (comment)); moreover one can always fall back on mpllocalfreetype if everything else fails...
Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants