[WIP] Upgrade the LassoSelector #5751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea what this error means: ERROR: matplotlib.tests.test_coding_standards.test_pep8_conformance_installed_files
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/matplotlib/matplotlib/venv/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
File "/home/travis/build/matplotlib/matplotlib/lib/matplotlib/tests/test_coding_standards.py", line 249, in test_pep8_conformance_installed_files
expected_bad_files=expected_bad_files)
File "/home/travis/build/matplotlib/matplotlib/lib/matplotlib/tests/test_coding_standards.py", line 155, in assert_pep8_conformance
'{0}'.format('\n '.join(unexpectedly_good)))
ValueError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
*/matplotlib/widgets.py |
|
That means you need to remove the wigets.py from the black list of 'known bad' files in |
|
Gotcha, updated. |
| else: | ||
| print(self.verts) | ||
| self.verts[-1] = (event.xdata, event.ydata) | ||
| print(self.verts) |
There was a problem hiding this comment.
do we really want to have these prints here?
|
Closing in favor of #5786. |
|
Reopening this one, because #5786 turned out to be a lot harder than I hoped. |
3eb1c23 to
327f2be
Compare
|
On second thought, I am going to close this one, and re-address the lasso after adding the paint and line tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to draw polygons, and to clear the selection (which I do in the last part of this demo).