Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Upgrade the LassoSelector #5751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[WIP] Upgrade the LassoSelector #5751

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4dcdab9
Upgrade the lassoselector
blink1073 Dec 26, 2015
133c0ce
Fix failing test
blink1073 Dec 26, 2015
a2c36ba
Beef up the lasso selector test
blink1073 Dec 27, 2015
5e0e45b
Pep8 fixes
blink1073 Dec 27, 2015
f6f80de
Remove extra print statements
blink1073 Dec 28, 2015
5e6f9bd
Rename modifier to be more clear
blink1073 Dec 28, 2015
136e170
Rename modifier to be more clear
blink1073 Dec 28, 2015
176387f
Preserve backward compatibility for onmove
blink1073 Dec 28, 2015
e8b2aff
Revert changes to nbagg_uat
blink1073 Dec 28, 2015
327f2be
Clean up clear logic and handle key release
blink1073 Jan 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up clear logic and handle key release
  • Loading branch information
@blink1073
blink1073 committed Nov 5, 2016
commit 327f2be7c463708e2339420e9d6bd08cf371c12e
25 changes: 10 additions & 15 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,7 @@ def on_key_press(self, event):
for artist in self.artists:
artist.set_visible(False)
self.update()
self._clear(event)
self.eventpress = None
return
for (state, modifier) in self.state_modifier_keys.items():
if modifier in key:
Expand All @@ -1662,11 +1662,6 @@ def _on_key_press(self, event):
"""
pass

def _clear(self, event):
"""Clear event handler - use for widget-specific clearing actions.
"""
pass

def on_key_release(self, event):
"""Key release event handler and validator"""
if self.active:
Expand Down Expand Up @@ -2531,25 +2526,24 @@ def _press(self, event):
self.verts is None):
self.verts = [(event.xdata, event.ydata)]

self.line.set_visible(True)
def _on_key_release(self, event):
if event.key == self.state_modifier_keys['polygon']:
if self._override_press:
self._finish(event)

def onrelease(self, event):
self.release(event)

def _clear(self, event):
self.verts = None
self.line.set_data([[], []])
self.line.set_visible(False)
self.update()

def _finish(self, event):
self.verts.append(self.verts[0])
self.line.set_data(list(zip(*self.verts)))
self.update()
self.onselect(self.verts)
if not self.persist:
self._clear(event)
self.line.set_data([[], []])
self.line.set_visible(False)
self._override_press = False
self.verts = None
self.update()

def _release(self, event):
if self.verts is None:
Expand All @@ -2566,6 +2560,7 @@ def _release(self, event):
def _onmove(self, event):
if self.verts is None:
return
self.line.set_visible(True)
if event.key == self.state_modifier_keys['polygon']:
if len(self.verts) == 1:
self.verts.append((event.xdata, event.ydata))
Expand Down