Fix slider widget polygon #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 10, 2011
…ce it doesn't circumvent the Polygon.set_closed method. axhspan and axvspan should have been declared closed all along.
Closed
|
Thanks for tracking this down. I propose an alternative in #581 that doesn't change the behavior (or rather circumvent the existing behavior) of Polygon.set_closed(). The solution is primarily to declare axhspan and axvspan as closed (which they really should have been all along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the Slider widget. When moving the sliders in slider_demo.py the blue polygons change to triangles. Similar, if valmin == valinit when the Slider widget is initialized, the polygon is truncated and becomes a triangle. Not sure yet if this patch has unwanted side effects.