Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature: Interactive Selector Tools #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 42 commits into from

Conversation

blink1073
Copy link
Member

See discussion in #5782.

Implements RectangleTool, EllipseTool, and LineTool to flesh out the base class requirements. I'll save Lasso, Polygon and Span for subsequent PRs.

selector_tools

selector_tools

@blink1073 blink1073 changed the title [WIP] Feature: Interactive Selector Tools Feature: Interactive Selector Tools Jan 2, 2016
@blink1073
Copy link
Member Author

Ready for review.

@blink1073
Copy link
Member Author

I've still got more comments to write, including the docstring.interp trick.

@blink1073
Copy link
Member Author

I decided to do all the tools at once (and add the paint tool), because it will better inform what the base class should look like. I'll also add a UAT notebook.

@blink1073
Copy link
Member Author

@pelson @tacaswell, I propose the following:
The Rectangle and Ellipse tools each get three resize handles and one rotation handle. The RegularPolygon tool gets a resize handle and a rotation handle.
The Lasso Tool gets no handles.
All tools are moved by picking on the patch and not on a handle.

test

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 16, 2016
@blink1073
Copy link
Member Author

Closing in favor of implemented the Painter widget only in #7411. I bit off more than I can chew with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants