lines.py: fix bugs in marker alpha and edge colors #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs are fixed: 1) plt.plot(np.arange(3),'ro', mec='none') was not plotting anything because 'none' was setting the edgecolor alpha to 0, and that alpha was being propagated to gc, overriding the face color. The 'none' case needs to be trapped, not passed on to the GraphicsContext. 2) plt.plot(np.arange(3), 'r.') was drawing a black edge around the point; same for 'r,'; the markers.py refactoring turned the point and pixel markers into filled markers, with their default black borders. The solution here was to special-case them in Line2D. They do need to be filled, with edges of the same color; otherwise the pixel can end up nearly invisible, and the point could end up as a donut.
mdboom
added a commit
that referenced
this pull request
Nov 28, 2011
lines.py: fix bugs in marker alpha and edge colors
|
Looks good. Merging. |
|
I'm getting this problem again on current development branch (1.5.x). In Out[2], I see nothing plotted: ~/matplotlib (master)$ ipython
Python 2.7.6 (default, Aug 25 2014, 18:32:19)
Type "copyright", "credits" or "license" for more information.
IPython 2.2.0 -- An enhanced Interactive Python.
? -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help -> Python's own help system.
object? -> Details about 'object', use 'object??' for extra details.
In [1]: %matplotlib
Using matplotlib backend: TkAgg
In [2]: import matplotlib; import matplotlib.pyplot as plt; import numpy as np; plt.plot(np.arange(3),'ro', mec='none')
Out[2]: [<matplotlib.lines.Line2D at 0x4171610>]
In [3]: import platform; platform.release()
Out[3]: '3.10.36-el5.ia32e.lime.0'
In [4]: matplotlib
Out[4]: <module 'matplotlib' from '/apps/stonefs1/azhu/venv/el5-stonelib/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/__init__.pyc'>
In [5]: matplotlib.__version__
Out[5]: '1.5.x'However this plots fine on matplotlib 1.4. Here's most recent commit in source code for 1.5.x build: ~/matplotlib (master)$ git log -n 2
commit 5305f4ace715e0bf17f1892203cc7062a48a285c
Merge: 0a96efb c0995e5
Author: Jens Hedegaard Nielsen <[email protected]>
Date: Tue Oct 21 13:30:02 2014 +0100
Merge pull request #3675 from mdboom/doc-build-warnings
Additional Warnings in docs build on travis after merge of decxxCan someone confirm? Should I open a new issue? |
|
@azjps Can you please open this as a new issue, just to make keeping track of it easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs are fixed:
plt.plot(np.arange(3),'ro', mec='none')
was not plotting anything because 'none' was setting the
edgecolor alpha to 0, and that alpha was being propagated
to gc, overriding the face color. The 'none' case needs to
be trapped, not passed on to the GraphicsContext.
plt.plot(np.arange(3), 'r.')
was drawing a black edge around the point; same for 'r,';
the markers.py refactoring turned the point and pixel markers
into filled markers, with their default black borders. The
solution here was to special-case them in Line2D. They do
need to be filled, with edges of the same color; otherwise
the pixel can end up nearly invisible, and the point could
end up as a donut.