cleaned up 3 examples [MEP12] #6488
Conversation
|
👍 will merge after CI passes. |
| """Timeline graph comparison with aligned colored annotation. | ||
|
|
||
| This example shows lines tracking change over time. It features dashed | ||
| lines at fixed increments on the Y axis. |
There was a problem hiding this comment.
being a bit pedantic here, but this paragraph could be used to describe just about any plot. I would just leave it out, or add a some info that is more specific to this example. In particular, with MEP12, we are looking for descriptions that not only describe the figure, but also describe what feature of matplotlib is being showcased.
There was a problem hiding this comment.
This one is a particularly flexibility testing example.
There was a problem hiding this comment.
What about something like...
"""
A graph of multiple time series which demonstrates extensive custom
styling of plot frame, tick lines and labels, and line graph properties.
Also demonstrates the custom placement of text labels along the right edge
as an alternative to a conventional legend.
"""
|
@aneda if you don't have time I don't mind taking over this PR to get it merged |
|
@fariza go ahead! I had forgotten about this and I'd thought it was done |
| @@ -1,4 +1,4 @@ | |||
| # Box plots with custom fill colors | |||
| """Box plots with custom fill colors.""" | |||
There was a problem hiding this comment.
It would be worth having a small description here as well.
There was a problem hiding this comment.
You are making me work :)
Something like:
"This plot illustrates how to create two types of boxplots (rectangular and notch), and how to fill them with custom colors by accessing some properties of the artists of the boxplots."
If we'd go with this description, I'd replace the title with something shorter: "Colored box plots"
But with this description, I'd remove the horizontal grid lines and replace the setp with ax.set_xticklabels.
There was a problem hiding this comment.
I'm not convinced, @WeatherGod what do you think?
|
Sorry for my noise on this :backs slowly away: |
|
@tacaswell Are we changing the title when we approve the PR or not? The PR review guidelines say so, but you undid your title change :) |
|
@tacaswell @WeatherGod I just pushed the replacement PR to finish this review process, |
The following three examples:
-- boxplot_color_demo.py
-- boxplot_vs_violin_demo.py
-- bachelors_degrees_by_gender.py