Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Boxplot color demo update #7324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2016
Merged

Conversation

phobson
Copy link
Member

@phobson phobson commented Oct 21, 2016

supersedes #6488 and #7317


import matplotlib.pyplot as plt
import numpy as np

# Random test data
np.random.seed(123)
all_data = [np.random.normal(0, std, 100) for std in range(1, 4)]
all_data = [np.random.normal(0, std, size=(100, 4)) for std in range(1, 4)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not keep the size as just 100?

@ivanov
Copy link
Member

ivanov commented Oct 21, 2016

I added some minor typo fixes, and additional axes labels that I think are useful.
phobson#1

@QuLogic
Copy link
Member

QuLogic commented Oct 21, 2016

Can you please rebase and remove the extra merge commit?

@phobson phobson force-pushed the boxplot-demo-update branch from bbb9994 to 8291567 Compare October 21, 2016 19:59
@ivanov
Copy link
Member

ivanov commented Oct 21, 2016

👍 Looks good to me!

@NelleV NelleV merged commit a00932e into matplotlib:master Oct 21, 2016
@NelleV
Copy link
Member

NelleV commented Oct 21, 2016

Hum… I was so happy to see @ivanov starting to review again that I merged before travis had time to finish. We'll see…

Thanks @phobson for the patch!

@phobson phobson deleted the boxplot-demo-update branch October 21, 2016 21:45
@phobson
Copy link
Member Author

phobson commented Oct 21, 2016

@NelleV thanks for the merge. Looks like Travis as happy & AppVeyor canceled itself after the merge (phew)

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Oct 22, 2016
@QuLogic QuLogic added the MEP: MEP12 gallery and examples improvements label Oct 22, 2016
@phobson
Copy link
Member Author

phobson commented Oct 25, 2016

I'll take care of it as soon I can get back on GH. See my comment to Paul
above :/

On Fri, Oct 21, 2016 at 11:55 AM, Elliott Sales de Andrade <
[email protected]> wrote:

Can you please rebase and remove the extra merge commit?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7324 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHCo2KmH79KhdYOAnQx94I3e8cnTolUks5q2QqSgaJpZM4KdbDj
.

@phobson
Copy link
Member Author

phobson commented Oct 25, 2016

Thanks Paul. I'm getting notification emails, but I can access github.com
or push ATM because of the Dyn DDoS
http://gizmodo.com/this-is-probably-why-half-the-internet-shut-down-today-1788062835
:/

On Fri, Oct 21, 2016 at 10:58 AM, Paul Ivanov [email protected]
wrote:

I added some minor typo fixes, and additional axes labels that I think are
useful.
phobson#1 phobson#1


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7324 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHCoxjKBza_DNXR6GpyyV-gy_t-AxTDks5q2P05gaJpZM4KdbDj
.

@phobson
Copy link
Member Author

phobson commented Oct 25, 2016

I meant to. Thanks for catching that.

On Fri, Oct 21, 2016 at 10:18 AM, Paul Ivanov [email protected]
wrote:

@ivanov commented on this pull request.

In examples/statistics/boxplot_color_demo.py
#7324 (review)
:

import matplotlib.pyplot as plt
import numpy as np

Random test data

np.random.seed(123)
-all_data = [np.random.normal(0, std, 100) for std in range(1, 4)]
+all_data = [np.random.normal(0, std, size=(100, 4)) for std in range(1, 4)]

Any reason to not keep the size as just 100?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7324 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHCozgOUZMkOyQ0kzwjZEPua8Z_l1yuks5q2PPIgaJpZM4KdbDj
.

@QuLogic
Copy link
Member

QuLogic commented Oct 25, 2016

Err, those got through a bit late...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants