-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Add painter widget #7411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add painter widget #7411
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d2a2350
Add painter widget
blink1073 1933b4c
Undo accidental changes
blink1073 bf3219c
Update docs and allow cmap to be passed in
blink1073 908f0b8
Add example and enforce integer image extents
blink1073 a49725f
Fix overlay setter and add tests
blink1073 cdcd45e
Add handling of state_modifier_keys
blink1073 2f6eb99
Clear the labels when resizing but update size
blink1073 10ddacb
Address review comments
blink1073 3e3d9bd
Add a note about setting the color
blink1073 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clear the labels when resizing but update size
- Loading branch information
commit 2f6eb99d0cade736c5bbf9144a3a7f87fa09facb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be able to use
_image.resamplein the same way thatimshoweventually does if you want take a stab at preserving the overlay.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That uses a lot of private APIs, I'd prefer to keep this simple. I added a note about the clearing behavior in the docs.