Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add painter widget #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Add painter widget #7411

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d2a2350
Add painter widget
blink1073 Nov 5, 2016
1933b4c
Undo accidental changes
blink1073 Nov 5, 2016
bf3219c
Update docs and allow cmap to be passed in
blink1073 Nov 5, 2016
908f0b8
Add example and enforce integer image extents
blink1073 Nov 5, 2016
a49725f
Fix overlay setter and add tests
blink1073 Nov 5, 2016
cdcd45e
Add handling of state_modifier_keys
blink1073 Nov 6, 2016
2f6eb99
Clear the labels when resizing but update size
blink1073 Nov 14, 2016
10ddacb
Address review comments
blink1073 Nov 15, 2016
3e3d9bd
Add a note about setting the color
blink1073 Nov 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add handling of state_modifier_keys
  • Loading branch information
@blink1073
blink1073 committed Nov 6, 2016
commit cdcd45ea40fd74b4c0e8e4e7c6964d275ec89a80
6 changes: 4 additions & 2 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,7 +2631,7 @@ def test(x, y):

def __init__(self, ax, on_select=None, overlay_props=None,
cursor_props=None, radius=5, cmap=LABELS_CMAP,
useblit=True, button=None):
useblit=True, button=None, state_modifier_keys=None):
"""
Parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use numpydoc style for new documentation. Basically all you need is to add some underlining:

Parameters
----------

and then remove the unnecessary emphasis on the parameter names.


Expand All @@ -2652,9 +2652,11 @@ def __init__(self, ax, on_select=None, overlay_props=None,
- Whether to use blitting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary bullet point. Also, indent is only 3 spaces instead of 4.

*button* : list
The button numbers supported for the tool (defaults to [1, 2, 3])
*state_modifier_keys* : dict
A mapping of key names to state modifiers.
"""
super(Painter, self).__init__(ax, on_select,
useblit=useblit, button=button)
useblit=useblit, button=button, state_modifier_keys=None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to match the opening ( to follow PEP8, or there can be no arguments on the first line.

self.cmap = cmap
self._previous = None
self._overlay = None
Expand Down