Update and shrink images a bit #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's available on all releases we'd use.
Even using the full container, and not the minimal one, has some immediate benefit on image size. Plus, as noted in the python image's docs, it can help save space due to common layers.
Also, de-verbose it because it outputs a ton of extra information.
podman build --tag matplotlib:dev -f ./Dockerfile
cd ../matplotlib
podman run -ti -v ./:/mpl_source matplotlib:dev bash -c "pip install /mpl_source && make -C/mpl_source/doc html"
podman run -ti -v ./:/mpl_source matplotlib:dev bash -c "pip install -e /mpl_source && cd /mpl_source && pytest -n4" is how I am using it. |
|
I'm going to go ahead and merge this. |
Okay, so one idea here that might work that I explore a bit in PR #8 is to use the following pattern this is basically the same as what you have except that it also explicitly sets the working directory to be in the example you gave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a variety of things (see commits) to update and shrink the images. This lines up some things with matplotlib/matplotlib#16848.
I got rid of
condabecause everything ispip-installed anyway, so it's not really helping us. Switching from xenial to bionic would have saved 150M more, but instead I went with the official python image as base, due to the reason listed in its docs of better layer sharing. The pre-installed packages also cut out on extra install steps for us.Using the
fonts-humor-sanspackage adds 12 M for some reason, but droppinglibgeos-devsaves 3M. Bigger savings come from dropping caches for 84M and switching base images for 628M. Overall, the image is 75% of its original size. Most of the remaining size is probably from LaTeX, and I don't think Debian has any finer-granularity packages for that (maybe Fedora would help there, but I don't want to change the container that much arbitrarily.)