ENH: add build arg to control Python base #6
Conversation
Dockerfile
Outdated
| ARG BASE=3.8 | ||
| FROM python:$BASE |
There was a problem hiding this comment.
@tacaswell looks good. I'm used to just having the image with tag as the whole build arg, but I think this will work but I will check and then confirm.
There was a problem hiding this comment.
Yeah, this works. My default is
ARG BUILDER_IMAGE=python:3.8
FROM ${BUILDER_IMAGE} as builder
to just make things very explicit (the builder stuff is just because I almost always use multistage builds but probably not needed here now). But I have confirmed that
docker build . \
-f Dockerfile \
--build-arg BASE=3.8 \
--tag matplotlib/mpl-docker:debug-3.8
works.
Dockerfile
Outdated
| ARG BASE=3.8 | ||
| FROM python:$BASE |
There was a problem hiding this comment.
Yeah, this works. My default is
ARG BUILDER_IMAGE=python:3.8
FROM ${BUILDER_IMAGE} as builder
to just make things very explicit (the builder stuff is just because I almost always use multistage builds but probably not needed here now). But I have confirmed that
docker build . \
-f Dockerfile \
--build-arg BASE=3.8 \
--tag matplotlib/mpl-docker:debug-3.8
works.
Dockerfile
Outdated
| @@ -1,4 +1,5 @@ | |||
| FROM python:3.7 | |||
| ARG BASE=3.8 | |||
There was a problem hiding this comment.
| ARG BASE=3.8 | |
| ARG BASE=3.8-slim |
Might try using the slim image to bring down the size?
|
I did not use
|
|
whoops, Matplotlib does not build in this image any more, will put that back in #8 |
|
@QuLogic Ah sorry. My bad. |
|
@QuLogic If it is of interest, I can later do a comparison study of how much space can be saved if the relevant packages are added in as compared to using the full image. This is what I have done in other images to shave off tens of MB here and there, but I'm not sure how much of interest that is here. |
|
I'm fairly certain it's smaller (but I don't remember by how much), but I don't really know that we decided what our target is, i.e., a single CI/developer system or a CI/developer with shared existing images. |
This will let us control with version of the Python image we build on top of.